Instadapp/dsa-connectors-old
1
0
Fork 0
mirror of https://github.com/Instadapp/dsa-connectors-old.git synced 2024-07-29 22:47:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

update readme requirement

Browse Source
This commit is contained in:
Sowmay Jain 2020-05-04 15:45:08 +10:00
parent 13bbb95c58
commit aa877f464f
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
README.md
View File

@ -13,16 +13,19 @@ Connectors are standard modules that let DeFi Smart Account interact with variou
## Requirements ## Requirements
Be sure to comply with the requirements while building connectors for better compatibility.
- Import common files from `contracts/common` directory. - Import common files from `contracts/common` directory.
- The contracts should not have `selfdestruct()`. - The contracts should not have `selfdestruct()`.
- The contracts should not have `delegatecall()`. - The contracts should not have `delegatecall()`.
- Use `uint(-1)` for maximum amount everywhere. - Use `uint(-1)` for maximum amount everywhere.
- Use `getEthAddr()` to denote Ethereum (non-ERC20). - Use `getEthAddr()` to denote Ethereum (non-ERC20).
- Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc. - Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc.
- While giving ERC20 allowance to contracts, only approve() the limited amount, which needs to be 0 by the end of the spells. - Only `approve()` limited amount While giving ERC20 allowance, which strictly needs to be 0 by the end of the spell.
- If required, Add two additional parameter, `getId` & `setId` in external public functions.
<!-- - If required, Add two additional parameter, `getId` & `setId` in external public functions.
- Use `getUint()` or `setUint()` functions to fetch or store values. - Use `getUint()` or `setUint()` functions to fetch or store values.
- Call `emitEvent()` after every external public functions. - Call `emitEvent()` after every external public functions. -->
Be sure to check [this mock file](https://github.com/InstaDApp/dsa-connectors/blob/master/contracts/connectors/mock.sol) for reference. Be sure to check [this mock file](https://github.com/InstaDApp/dsa-connectors/blob/master/contracts/connectors/mock.sol) for reference.