From aa877f464fa902be3fd42964de9a0e35b09fa3ac Mon Sep 17 00:00:00 2001 From: Sowmay Jain Date: Mon, 4 May 2020 15:45:08 +1000 Subject: [PATCH] update readme requirement --- README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index c8b2591..4b9c12a 100644 --- a/README.md +++ b/README.md @@ -13,16 +13,19 @@ Connectors are standard modules that let DeFi Smart Account interact with variou ## Requirements +Be sure to comply with the requirements while building connectors for better compatibility. + - Import common files from `contracts/common` directory. - The contracts should not have `selfdestruct()`. - The contracts should not have `delegatecall()`. - Use `uint(-1)` for maximum amount everywhere. - Use `getEthAddr()` to denote Ethereum (non-ERC20). - Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc. -- While giving ERC20 allowance to contracts, only approve() the limited amount, which needs to be 0 by the end of the spells. -- If required, Add two additional parameter, `getId` & `setId` in external public functions. +- Only `approve()` limited amount While giving ERC20 allowance, which strictly needs to be 0 by the end of the spell. + + Be sure to check [this mock file](https://github.com/InstaDApp/dsa-connectors/blob/master/contracts/connectors/mock.sol) for reference.