Instadapp/dsa-connectors-old
1
0
Fork 0
mirror of https://github.com/Instadapp/dsa-connectors-old.git synced 2024-07-29 22:47:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated readme.md

Browse Source
This commit is contained in:
Thrilok Kumar 2020-05-03 05:40:50 +05:30
parent 2b4765d243
commit 494bf080e5
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
README.md
View File

@ -8,7 +8,7 @@ Connectors are standardized modules that let Smart Account interact with various
2. Create a feature branch: `git checkout -b new-connector` 2. Create a feature branch: `git checkout -b new-connector`
3. Commit changes: `git commit -am 'Added a connector'` 3. Commit changes: `git commit -am 'Added a connector'`
4. Push to the remote branch: `git push origin new-connector` 4. Push to the remote branch: `git push origin new-connector`
5. Create a new Pull Request 5. Create a new Pull Request.
## Requirements ## Requirements
@ -16,8 +16,9 @@ Connectors are standardized modules that let Smart Account interact with various
- The contracts should not have `delegatecall()`. - The contracts should not have `delegatecall()`.
- Use `uint(-1)` for maximum amount everywhere. - Use `uint(-1)` for maximum amount everywhere.
- Import files from common directory. - Import files from common directory.
- If needed, add `getId` & `setId`, two additional parameter for external public facing functions to fetch or store values.
- Use `getEthAddr()` to get an address to denote Ethereum (non-ERC20) related operations. - Use `getEthAddr()` to get an address to denote Ethereum (non-ERC20) related operations.
- Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc.
- If needed, add `getId` & `setId`, two additional parameter for external public facing functions to fetch or store values.
- Use `getUint()` or `setUint()` functions to fetch or store values. - Use `getUint()` or `setUint()` functions to fetch or store values.
- Call `emitEvent()` after every external public facing functions to follow a common event standard for better analytics. - Call `emitEvent()` after every external public facing functions to follow a common event standard for better analytics.