From 494bf080e56d222b45aac9fd336f001e63c8a745 Mon Sep 17 00:00:00 2001 From: Thrilok Kumar Date: Sun, 3 May 2020 05:40:50 +0530 Subject: [PATCH] Updated readme.md --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 064e979..be0a75d 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ Connectors are standardized modules that let Smart Account interact with various 2. Create a feature branch: `git checkout -b new-connector` 3. Commit changes: `git commit -am 'Added a connector'` 4. Push to the remote branch: `git push origin new-connector` -5. Create a new Pull Request +5. Create a new Pull Request. ## Requirements @@ -16,8 +16,9 @@ Connectors are standardized modules that let Smart Account interact with various - The contracts should not have `delegatecall()`. - Use `uint(-1)` for maximum amount everywhere. - Import files from common directory. -- If needed, add `getId` & `setId`, two additional parameter for external public facing functions to fetch or store values. - Use `getEthAddr()` to get an address to denote Ethereum (non-ERC20) related operations. +- Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc. +- If needed, add `getId` & `setId`, two additional parameter for external public facing functions to fetch or store values. - Use `getUint()` or `setUint()` functions to fetch or store values. - Call `emitEvent()` after every external public facing functions to follow a common event standard for better analytics.