Instadapp/chains
1
0
Fork 0
mirror of https://github.com/Instadapp/chains.git synced 2024-07-29 22:37:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
8550418b3e
chains/maintainer_checklist.md
Vladimir Pouzanov b320a5da36
Clean up the maintainer_checklist.md (#2441) 
Updates the maintainer_checklist formatting so that the list items render properly.
2023-03-17 19:09:45 +01:00

596 B
Raw Blame History

A checklist for things to check before merging a chain PR.

  • If the PR contains explorers claim to adhere to EIP3091 - check if they really do.
  • If the PR contains icons:
    • ipfs get all icon CIDs
    • check if the size of the icons you got match the size given in the PR
  • Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks)
  • Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)

If anyone has ideas on how to automate these things in CI - PRs welcome!