Instadapp/chains
1
0
Fork 0
mirror of https://github.com/Instadapp/chains.git synced 2024-07-29 22:37:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
maintainer-checklist
chains/maintainer_checklist.md
ligi 20ac6b0468
Update maintainer_checklist.md
2022-10-25 23:46:28 +02:00

586 B
Raw Permalink Blame History

A checklist for things to check before merging a chain PR.

If the PR contains explorers claim to adhere to EIP3091 - check if they really do. If the PR contains icons:

  • ipfs get all icon CIDs
  • check if the size of the icons you got match the size given in the PR Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks) Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)

If anyone has ideas on how to automate these things in CI - PRs welcome!