Instadapp/chains
1
0
Fork 0
mirror of https://github.com/Instadapp/chains.git synced 2024-07-29 22:37:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Create maintainer_checklist.md

Browse Source
This commit is contained in:
ligi 2022-10-25 23:41:00 +02:00
parent 874de394fb
commit cd222ca256
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
maintainer_checklist.md Normal file
View File

@ -0,0 +1,8 @@
A checklist for things to check before merging a chain PR.
If the PR contains explorers claim to adhere to EIP3091 - check if they really do.
If the PR contains icons:
* `ipfs get` all icon CIDs
* check if the size of the icons you got match the size given in the PR
Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks)
Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)