From cd222ca25690dbbec7cda6ac5d5f22ea95fc90ea Mon Sep 17 00:00:00 2001 From: ligi Date: Tue, 25 Oct 2022 23:41:00 +0200 Subject: [PATCH] Create maintainer_checklist.md --- maintainer_checklist.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 maintainer_checklist.md diff --git a/maintainer_checklist.md b/maintainer_checklist.md new file mode 100644 index 00000000..de3ead61 --- /dev/null +++ b/maintainer_checklist.md @@ -0,0 +1,8 @@ +A checklist for things to check before merging a chain PR. + +If the PR contains explorers claim to adhere to EIP3091 - check if they really do. +If the PR contains icons: + * `ipfs get` all icon CIDs + * check if the size of the icons you got match the size given in the PR +Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks) +Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)