Instadapp/chains
1
0
Fork 0
mirror of https://github.com/Instadapp/chains.git synced 2024-07-29 22:37:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up the maintainer_checklist.md (#2441)

Browse Source 
Updates the maintainer_checklist formatting so that the list items render properly.
This commit is contained in:
Vladimir Pouzanov 2023-03-17 18:09:45 +00:00 committed by GitHub
parent 05e0907a37
commit b320a5da36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
maintainer_checklist.md
View File

@ -1,10 +1,10 @@
A checklist for things to check before merging a chain PR. A checklist for things to check before merging a chain PR.
If the PR contains explorers claim to adhere to EIP3091 - check if they really do. * If the PR contains explorers claim to adhere to EIP3091 - check if they really do.
If the PR contains icons: * If the PR contains icons:
* `ipfs get` all icon CIDs * `ipfs get` all icon CIDs
* check if the size of the icons you got match the size given in the PR * check if the size of the icons you got match the size given in the PR
Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks) * Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks)
Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750) * Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)
If anyone has ideas on how to automate these things in CI - PRs welcome! If anyone has ideas on how to automate these things in CI - PRs welcome!