From b320a5da367b49749bd06f3d8793788bb6d81c93 Mon Sep 17 00:00:00 2001 From: Vladimir Pouzanov Date: Fri, 17 Mar 2023 18:09:45 +0000 Subject: [PATCH] Clean up the maintainer_checklist.md (#2441) Updates the maintainer_checklist formatting so that the list items render properly. --- maintainer_checklist.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/maintainer_checklist.md b/maintainer_checklist.md index 2dbcca73..6c5d0e21 100644 --- a/maintainer_checklist.md +++ b/maintainer_checklist.md @@ -1,10 +1,10 @@ A checklist for things to check before merging a chain PR. -If the PR contains explorers claim to adhere to EIP3091 - check if they really do. -If the PR contains icons: - * `ipfs get` all icon CIDs - * check if the size of the icons you got match the size given in the PR -Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks) -Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750) +* If the PR contains explorers claim to adhere to EIP3091 - check if they really do. +* If the PR contains icons: + * `ipfs get` all icon CIDs + * check if the size of the icons you got match the size given in the PR +* Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks) +* Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750) If anyone has ideas on how to automate these things in CI - PRs welcome!