2022-10-25 21:41:00 +00:00
|
|
|
A checklist for things to check before merging a chain PR.
|
|
|
|
|
|
2023-03-17 18:09:45 +00:00
|
|
|
* If the PR contains explorers claim to adhere to EIP3091 - check if they really do.
|
|
|
|
|
* If the PR contains icons:
|
|
|
|
|
* `ipfs get` all icon CIDs
|
|
|
|
|
* check if the size of the icons you got match the size given in the PR
|
|
|
|
|
* Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks)
|
|
|
|
|
* Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)
|
2022-10-25 21:46:28 +00:00
|
|
|
|
|
|
|
|
If anyone has ideas on how to automate these things in CI - PRs welcome!
|
