From 79779c92691f38de44533546d895b10f5982b26e Mon Sep 17 00:00:00 2001 From: Thrilok Kumar Date: Tue, 25 Aug 2020 19:51:21 +0530 Subject: [PATCH] added more require statements --- contracts/registry.sol | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/contracts/registry.sol b/contracts/registry.sol index 98544d0..cc757ba 100644 --- a/contracts/registry.sol +++ b/contracts/registry.sol @@ -24,8 +24,8 @@ contract Registry { mapping (address => bool) public chief; mapping (address => bool) public signer; - mapping (address => address) public poolToken; mapping (address => bool) public isPool; + mapping (address => address) public poolToken; mapping (address => address) public poolLogic; mapping (address => uint) public poolCap; mapping (address => uint) public insureFee; @@ -89,8 +89,9 @@ contract Registry { * @param token ERC20 token address * @param pool pool address */ - function addPool(address token, address pool) external isMaster { // TODO: all good? + function addPool(address token, address pool) external isMaster { require(token != address(0) && pool != address(0), "invalid-address"); + require(poolToken[token] == address(0), "pool-already-added"); poolToken[token] = pool; emit LogAddPool(token, pool); } @@ -99,8 +100,9 @@ contract Registry { * @dev Remove Pool * @param token ERC20 token address */ - function removePool(address token) external isMaster { // TODO: all good? + function removePool(address token) external isMaster { require(token != address(0), "invalid-address"); + require(poolToken[token] != address(0), "pool-already-removed"); address poolAddr = poolToken[token]; delete poolToken[token]; emit LogRemovePool(token, poolAddr);