mirror of
https://github.com/Instadapp/trustwallet-assets.git
synced 2024-07-29 22:37:31 +00:00
fa6bba6228
* Do not automatically add tokens to denylist. * Removed orphan check; that case is OK Co-authored-by: Catenocrypt <catenocrypt@users.noreply.github.com>
121 lines
4.9 KiB
TypeScript
121 lines
4.9 KiB
TypeScript
import { chainsWithDenylist } from "./blockchains";
|
|
import {
|
|
getChainAssetsList,
|
|
getChainAllowlistPath,
|
|
getChainDenylistPath
|
|
} from "./repo-structure";
|
|
import { readFileSync, writeFileSync } from "./filesystem";
|
|
import {
|
|
arrayDiff,
|
|
arrayDiffNocase,
|
|
findCommonElementsOrDuplicates,
|
|
makeUnique
|
|
} from "./types";
|
|
import { ActionInterface, CheckStepInterface } from "./interface";
|
|
import { formatSortJson } from "./json";
|
|
import * as bluebird from "bluebird";
|
|
|
|
async function checkUpdateAllowDenyList(chain: string, checkOnly: boolean ): Promise<[boolean, string[], string[]]> {
|
|
const errorMsgs: string[] = [];
|
|
const warningMsgs: string[] = [];
|
|
const assets = getChainAssetsList(chain);
|
|
|
|
const allowlistPath = getChainAllowlistPath(chain);
|
|
const denylistPath = getChainDenylistPath(chain);
|
|
|
|
const currentAllowlistText = readFileSync(allowlistPath);
|
|
const currentDenylistText = readFileSync(denylistPath);
|
|
const currentAllowlist = JSON.parse(currentAllowlistText);
|
|
const currentDenylist = JSON.parse(currentDenylistText);
|
|
|
|
const commonElementsOrDuplicates = findCommonElementsOrDuplicates(currentAllowlist, currentDenylist);
|
|
if (commonElementsOrDuplicates && commonElementsOrDuplicates.length > 0) {
|
|
errorMsgs.push(`Denylist and allowlist for chain ${chain} should have no common elements or duplicates, found ${commonElementsOrDuplicates.length} ${commonElementsOrDuplicates[0]}`);
|
|
}
|
|
/*
|
|
const allowlistOrphan = arrayDiff(currentAllowlist, assets);
|
|
if (allowlistOrphan && allowlistOrphan.length > 0) {
|
|
// warning only
|
|
warningMsgs.push(`Allowlist for chain ${chain} contains non-exitent assets, found ${allowlistOrphan.length}, ${allowlistOrphan[0]}`);
|
|
}
|
|
*/
|
|
|
|
//const newDeny = makeUnique(currentDenylist.concat(allowlistOrphan));
|
|
const tempAssetsOrAllow = makeUnique(currentAllowlist.concat(assets));
|
|
const newAllow = makeUnique(arrayDiffNocase(tempAssetsOrAllow, currentDenylist));
|
|
//console.log(currentAllowlist.length, "vs.", newAllow.length);
|
|
//console.log(currentDenylist.length, "vs.", newDeny.length);
|
|
|
|
const wDiff1 = arrayDiffNocase(newAllow, currentAllowlist);
|
|
if (wDiff1.length > 0) {
|
|
// warning only
|
|
warningMsgs.push(`Some elements are missing from allowlist for chain ${chain}: ${wDiff1.length} ${wDiff1[0]}`);
|
|
}
|
|
const wDiff2 = arrayDiffNocase(currentAllowlist, newAllow);
|
|
if (wDiff2.length > 0) {
|
|
// warning only
|
|
warningMsgs.push(`Some elements should be removed from allowlist for chain ${chain}: ${wDiff2.length} ${wDiff2[0]}`);
|
|
}
|
|
|
|
/*
|
|
const bDiff1 = arrayDiffNocase(newDeny, currentDenylist);
|
|
if (bDiff1.length > 0) {
|
|
warningMsgs.push(`Some elements are missing from denylist for chain ${chain}: ${bDiff1.length} ${bDiff1[0]}`);
|
|
}
|
|
const bDiff2 = arrayDiffNocase(currentDenylist, newDeny);
|
|
if (bDiff2.length > 0) {
|
|
warningMsgs.push(`Some elements should be removed from denylist for chain ${chain}: ${bDiff2.length} ${bDiff2[0]}`);
|
|
}
|
|
*/
|
|
|
|
// additionally check for nice formatting, sorting:
|
|
const newAllowText = formatSortJson(newAllow);
|
|
if (newAllowText !== currentAllowlistText) {
|
|
warningMsgs.push(`Allowlist for chain ${chain}: not formatted nicely `);
|
|
}
|
|
const newDenyText = formatSortJson(currentDenylist); // formatSortJson(newDeny);
|
|
if (newDenyText !== currentDenylistText) {
|
|
warningMsgs.push(`Denylist for chain ${chain}: not formatted nicely `);
|
|
}
|
|
|
|
if (errorMsgs.length > 0 || warningMsgs.length > 0) {
|
|
// sg wrong, may need to fix
|
|
if (!checkOnly) {
|
|
// update
|
|
writeFileSync(allowlistPath, newAllowText);
|
|
writeFileSync(denylistPath, newDenyText);
|
|
console.log(`Updated allow and denylists for chain ${chain}`);
|
|
}
|
|
}
|
|
return [(errorMsgs.length == 0 && warningMsgs.length == 0), errorMsgs, warningMsgs];
|
|
}
|
|
|
|
export class Allowlists implements ActionInterface {
|
|
getName(): string { return "Allowlists"; }
|
|
|
|
getSanityChecks = null;
|
|
|
|
getConsistencyChecks(): CheckStepInterface[] {
|
|
const steps: CheckStepInterface[] = [];
|
|
chainsWithDenylist.forEach(chain => {
|
|
steps.push(
|
|
{
|
|
getName: () => { return `Allowlist and denylist for ${chain} should be consistent with assets`},
|
|
check: async () => {
|
|
const [isOK, errorMsgs, warningMsgs] = await checkUpdateAllowDenyList(chain, true);
|
|
if (!isOK) {
|
|
return [errorMsgs, warningMsgs];
|
|
}
|
|
return [[], []];
|
|
}
|
|
}
|
|
);
|
|
});
|
|
return steps;
|
|
}
|
|
|
|
async consistencyFix(): Promise<void> {
|
|
await bluebird.each(chainsWithDenylist, async (chain) => await checkUpdateAllowDenyList(chain, false));
|
|
}
|
|
}
|