From fa844cc2cd517be8ee2f543c3fa318e2b3545eff Mon Sep 17 00:00:00 2001 From: Sowmayjain Date: Mon, 25 Mar 2019 18:48:52 +0530 Subject: [PATCH] Fixed manage allowance bug. --- contracts/ProxyLogics/InstaKyber.sol | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/contracts/ProxyLogics/InstaKyber.sol b/contracts/ProxyLogics/InstaKyber.sol index 13e4fe5..7b09f21 100644 --- a/contracts/ProxyLogics/InstaKyber.sol +++ b/contracts/ProxyLogics/InstaKyber.sol @@ -85,6 +85,7 @@ contract Helper { require(msg.value == srcAmt, "not-enough-src"); ethQty = srcAmt; } else { + manageApproval(src, srcAmt); IERC20 tokenCall = IERC20(src); tokenCall.transferFrom(trader, address(this), srcAmt); } @@ -144,7 +145,6 @@ contract Swap is Helper { uint maxDestAmt ) public payable returns (uint destAmt) { - manageApproval(src, srcAmt); uint ethQty = getToken(msg.sender, src, srcAmt); (, uint slippageRate) = getExpectedRate(src, dest, srcAmt); @@ -184,7 +184,6 @@ contract Swap is Helper { uint srcAmt ) public payable returns (uint destAmt) { - manageApproval(src, srcAmt); uint ethQty = getToken(msg.sender, src, srcAmt); (, uint slippageRate) = getExpectedRate(src, dest, srcAmt);