Instadapp/smart-contract
1
0
Fork 0
mirror of https://github.com/Instadapp/smart-contract.git synced 2024-07-29 22:08:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1 from Sowmayjain/userwallet-changes

Browse Source 
isExecutable function to modifier
This commit is contained in:
Sowmay Jain 2019-03-26 00:24:38 +05:30 committed by GitHub
commit e6c0d977a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
contracts/UserWallet.sol
View File

@ -325,9 +325,9 @@ contract InstaWallet is UserManager, UserNote {
public
payable
note
isExecutable(_target)
returns (bytes memory response)
{
require(isExecutable(_target), "not-executable");
lastActivity = block.timestamp;
emit LogExecute(
msg.sender,
@ -359,17 +359,20 @@ contract InstaWallet is UserManager, UserNote {
* and if the sender is owner or contract itself or manager
* and if manager then Throws if target is default proxy address
*/
function isExecutable(address proxyTarget) public view returns (bool) {
modifier isExecutable(address proxyTarget) {
require(proxyTarget != address(0), "logic-proxy-address-required");
(bool isLogic, bool isDefault) = isLogicAuthorised(proxyTarget);
require(isLogic, "logic-proxy-address-not-allowed");
bool canExecute = false;
if (isAuth(msg.sender)) {
return true;
canExecute = true;
} else if (isManager(msg.sender) && !isDefault) {
return true;
canExecute = true;
} else {
return false;
canExecute = false;
}
require(canExecute, "not-executable");
_;
}
}