Instadapp/dsa-connectors
1
0
Fork 0
mirror of https://github.com/Instadapp/dsa-connectors.git synced 2024-07-29 22:37:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update how-to-add-new-connector.md

Browse Source
This commit is contained in:
Samyak Jain 2021-08-26 16:21:11 +05:30 committed by GitHub
parent fa4de09e1d
commit 92db8df3ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/how-to-add-new-connector.md
View File

@ -31,7 +31,7 @@ Few things to consider while writing the connector:
* `_eventParam` of `bytes` type: This will be the abi encoded event parameters * `_eventParam` of `bytes` type: This will be the abi encoded event parameters
* The contracts should not have `selfdestruct()` * The contracts should not have `selfdestruct()`
* The contracts should not have `delegatecall()` * The contracts should not have `delegatecall()`
* Use `uint(-1)` for maximum amount everywhere * Use `uint(-1)` of `type(uint256).max` for maximum amount everywhere
* Use `ethAddr` (declared in `Stores`) to denote Ethereum (non-ERC20) * Use `ethAddr` (declared in `Stores`) to denote Ethereum (non-ERC20)
* Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc * Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc
* Only `approve()` limited amount while giving ERC20 allowance, which strictly needs to be 0 by the end of the spell. * Only `approve()` limited amount while giving ERC20 allowance, which strictly needs to be 0 by the end of the spell.