From 466ce9b1e40c1c27c76c9e5e64a7b48e1f06b168 Mon Sep 17 00:00:00 2001 From: Thrilok Kumar Date: Sat, 9 May 2020 02:41:56 +0530 Subject: [PATCH] fixed .call bug --- contracts/connectors/1inch.sol | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contracts/connectors/1inch.sol b/contracts/connectors/1inch.sol index 373c4f9..9cc64b5 100644 --- a/contracts/connectors/1inch.sol +++ b/contracts/connectors/1inch.sol @@ -232,7 +232,9 @@ contract BasicResolver is Resolver { uint initalBal = getTokenBal(_buyAddr); - address(getOneInchAddress()).call.value(ethAmt)(callData); + // solium-disable-next-line security/no-call-value + (bool success, ) = address(getOneInchAddress()).call.value(ethAmt)(callData); + if (!success) revert("1Inch-swap-failed"); uint finalBal = getTokenBal(_buyAddr); uint buyAmt = sub(finalBal, initalBal);