Instadapp/dsa-connectors-old
1
0
Fork 0
mirror of https://github.com/Instadapp/dsa-connectors-old.git synced 2024-07-29 22:47:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated Readme

Browse Source
This commit is contained in:
Thrilok Kumar 2020-05-04 07:26:42 +05:30
parent 45ffbaf670
commit 13bbb95c58
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
README.md
View File

@ -19,6 +19,7 @@ Connectors are standard modules that let DeFi Smart Account interact with variou
- Use `uint(-1)` for maximum amount everywhere. - Use `uint(-1)` for maximum amount everywhere.
- Use `getEthAddr()` to denote Ethereum (non-ERC20). - Use `getEthAddr()` to denote Ethereum (non-ERC20).
- Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc. - Use `address(this)` instead of `msg.sender` for fetching balance on-chain, etc.
- While giving ERC20 allowance to contracts, only approve() the limited amount, which needs to be 0 by the end of the spells.
- If required, Add two additional parameter, `getId` & `setId` in external public functions. - If required, Add two additional parameter, `getId` & `setId` in external public functions.
- Use `getUint()` or `setUint()` functions to fetch or store values. - Use `getUint()` or `setUint()` functions to fetch or store values.
- Call `emitEvent()` after every external public functions. - Call `emitEvent()` after every external public functions.