mirror of
https://github.com/Instadapp/chains.git
synced 2024-07-29 22:37:19 +00:00
suggest to run gradle before submitting PR; (#2284)
* suggest to run gradle before submitting PR; Signed-off-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com> * Update README.md Co-authored-by: ligi <ligi@ligi.de> --------- Signed-off-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com> Co-authored-by: ligi <ligi@ligi.de>
This commit is contained in:
parent
7ac98b567f
commit
c253319e12
3
.gitignore
vendored
3
.gitignore
vendored
|
@ -10,4 +10,5 @@ output
|
|||
model/bin
|
||||
model/build
|
||||
processor/bin
|
||||
processor/build
|
||||
processor/build
|
||||
httpsloader/build
|
13
README.md
13
README.md
|
@ -91,7 +91,18 @@ There are also aggregated json files with all chains automatically assembled:
|
|||
The first pull request gets the chainID assigned. When creating a chain we can expect that you read EIP155 which states this repo.
|
||||
All pull request trying to replace a chainID because they think their chain is better than the other will be closed.
|
||||
The only way to get a chain reassigned is when the old chain gets deprecated. This can e.g. be used for testnets that are short lived. But then you will get the redFlag "reusedChaiID" that should be displayed in clients to warn them about the dangers here.
|
||||
|
||||
|
||||
## PR verification
|
||||
|
||||
Before submitting a PR, please verify that checks pass with:
|
||||
|
||||
```bash
|
||||
$ ./gradlew run
|
||||
|
||||
BUILD SUCCESSFUL in 7s
|
||||
9 actionable tasks: 9 executed
|
||||
```
|
||||
|
||||
## Usages
|
||||
### Wallets
|
||||
* [WallETH](https://walleth.org)
|
||||
|
|
Loading…
Reference in New Issue
Block a user