Instadapp/aave-protocol-v2
1
0
Fork 0
mirror of https://github.com/Instadapp/aave-protocol-v2.git synced 2024-07-29 21:47:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove whenNotPaused modifier for configurator functions. Added more test cases.

Browse Source
This commit is contained in:
David Racero 2020-09-14 14:36:12 +02:00
parent ad2581b0a0
commit b8a7237458
2 changed files with 47 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contracts/lendingpool/LendingPool.sol
View File

@ -711,7 +711,7 @@ contract LendingPool is VersionedInitializable, Pausable, ILendingPool {
address stableDebtAddress, address stableDebtAddress,
address variableDebtAddress, address variableDebtAddress,
address interestRateStrategyAddress address interestRateStrategyAddress
) external override onlyLendingPoolConfigurator whenNotPaused { ) external override onlyLendingPoolConfigurator {
_reserves[asset].init( _reserves[asset].init(
aTokenAddress, aTokenAddress,
stableDebtAddress, stableDebtAddress,
@ -731,7 +731,6 @@ contract LendingPool is VersionedInitializable, Pausable, ILendingPool {
external external
override override
onlyLendingPoolConfigurator onlyLendingPoolConfigurator
whenNotPaused
{ {
_reserves[asset].interestRateStrategyAddress = rateStrategyAddress; _reserves[asset].interestRateStrategyAddress = rateStrategyAddress;
} }

46
test/atoken-transfer.spec.ts
View File

@ -17,6 +17,7 @@ makeSuite('AToken: Transfer', (testEnv: TestEnv) => {
// ZERO_COLLATERAL, // ZERO_COLLATERAL,
COLLATERAL_BALANCE_IS_0, COLLATERAL_BALANCE_IS_0,
TRANSFER_NOT_ALLOWED, TRANSFER_NOT_ALLOWED,
IS_PAUSED,
} = ProtocolErrors; } = ProtocolErrors;
it('User 0 deposits 1000 DAI, transfers to user 1', async () => { it('User 0 deposits 1000 DAI, transfers to user 1', async () => {
@ -134,4 +135,49 @@ makeSuite('AToken: Transfer', (testEnv: TestEnv) => {
INVALID_TO_BALANCE_AFTER_TRANSFER INVALID_TO_BALANCE_AFTER_TRANSFER
); );
}); });
it('User 0 deposits 1000 DAI but reverts due pool is paused', async () => {
const {users, pool, dai, aDai, configurator} = testEnv;
const amountDAItoDeposit = await convertToCurrencyDecimals(dai.address, '1000');
await dai.connect(users[0].signer).mint(amountDAItoDeposit);
// user 0 deposits 1000 DAI
await dai.connect(users[0].signer).approve(pool.address, APPROVAL_AMOUNT_LENDING_POOL);
// Configurator pauses the pool
await configurator.pausePool();
await expect(
pool.connect(users[0].signer).deposit(dai.address, amountDAItoDeposit, users[0].address, '0')
).to.revertedWith(IS_PAUSED);
// Configurator unpauses the pool
await configurator.unpausePool();
});
it('User 0 burns 1000 aDAI but reverts due pool is paused', async () => {
const {users, pool, dai, aDai, configurator} = testEnv;
const amountDAItoDeposit = await convertToCurrencyDecimals(dai.address, '1000');
await dai.connect(users[0].signer).mint(amountDAItoDeposit);
// user 0 deposits 1000 DAI
await dai.connect(users[0].signer).approve(pool.address, APPROVAL_AMOUNT_LENDING_POOL);
await pool
.connect(users[0].signer)
.deposit(dai.address, amountDAItoDeposit, users[0].address, '0');
// Configurator pauses the pool
await configurator.pausePool();
// user tries to burn
await expect(
pool.connect(users[0].signer).withdraw(dai.address, amountDAItoDeposit)
).to.revertedWith(IS_PAUSED);
// Configurator unpauses the pool
await configurator.unpausePool();
});
}); });